Enable DFLASH support for additional model backends#22358
Merged
hnyls2002 merged 1 commit intosgl-project:mainfrom Apr 9, 2026
Merged
Enable DFLASH support for additional model backends#22358hnyls2002 merged 1 commit intosgl-project:mainfrom
hnyls2002 merged 1 commit intosgl-project:mainfrom
Conversation
mmangkad
requested review from
Fridge003,
ch-wan,
fzyzcjy,
ispobock and
merrymercy
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces DFLASH auxiliary hidden state capture across several models, including DeepSeek-V2, GPT-OSS, Kimi-K25, and the Qwen3 series. The changes primarily involve adding set_dflash_layers_to_capture and get_input_embeddings methods. Review feedback highlights several issues: a potential AttributeError and unsafe tuple unpacking in qwen3_vl.py, as well as inconsistencies in qwen3_5.py regarding layer index offsets, pipeline parallelism validation, and return type logic.
Contributor
Author
|
cc @hnyls2002, could you help check? I can confirm this works for all the available models |
Collaborator
|
/tag-and-rerun-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable DFLASH for additional supported models from the z-lab collection: https://huggingface.co/collections/z-lab/dflash
Based on #20547, landing this early to enable support for these models now without waiting for the DFlash spec v2 to merge